Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python eventlog parsing for measured boot attestation #97

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

galmasi
Copy link

@galmasi galmasi commented Mar 18, 2023

No description provided.

George Almasi added 2 commits March 15, 2023 13:59
Signed-off-by: George Almasi <gheorghe@us.ibm.com>
Signed-off-by: George Almasi <gheorghe@us.ibm.com>
Comment on lines +130 to +134
types of events), the event log parser is already doing so. NB we are
not aware of the `tpm2-tools` based event log parser doing any
self-checking. And of course the python based event log parser is
capable of generating PCR reference values in the same way
as `tpm2-tools`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tpm2-tools eventlog parser does validate the entries were possible against the digest and emits an error if it does not match.

Copy link
Author

@galmasi galmasi Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not looked [too much] at the tpm2_eventlog.c code -- consciously avoided looking there too much except to figure out why generated JSON outputs disagree.

A lot of EFIVAR type entries don't self-validate at the moment, but only when generated by certain BIOSes. No, I don't know why, and I haven't identified the failure parameters yet. Working on making that part of the CI unit tests, while improving the self-checking code that handles {accidentally|deliberately} malformed event logs.

@maugustosilva maugustosilva self-requested a review March 28, 2023 10:49
@maugustosilva
Copy link
Contributor

After discussing in the monthly meeting, I believe we reached a consensus that the enhancement proposal should move ahead, and thus LGTM. A new repository, https://github.com/keylime/python3-uefi-eventlog , was created, and we can all start to collectively review the code there.

@maugustosilva maugustosilva merged commit 9e8ed10 into keylime:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants