Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint: Fix issues related to R0201 #938

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

stefanberger
Copy link
Contributor

@stefanberger stefanberger commented Mar 23, 2022

This PR fixes the following pylint issues:

  • R0201 no-self-use

@stefanberger
Copy link
Contributor Author

@mpeters Thanks but let's run the tests first. Why are they not running?

@mpeters
Copy link
Member

mpeters commented Mar 23, 2022

Yeah, I wasn't going to merge until the tests had run, but then noticed they weren't running. https://www.githubstatus.com/ shows that actions are down, so we'll need to wait until they are back up.

@THS-on THS-on mentioned this pull request Mar 23, 2022
39 tasks
@THS-on
Copy link
Member

THS-on commented Mar 23, 2022

@stefanberger C0115 & C0116 are not really solved just not enabled in pylint. It seems like that another option is already disabling them. Manually enabling them returns a lot of warnings.

@stefanberger
Copy link
Contributor Author

@stefanberger C0115 & C0116 are not really solved just not enabled in pylint. It seems like that another option is already disabling them. Manually enabling them returns a lot of warnings.

Let me drop them.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
@stefanberger stefanberger changed the title pylint: Fix issues related to R0201 and remove C0115 and C0116 from disabled list pylint: Fix issues related to R0201 Mar 23, 2022
@mpeters mpeters merged commit 9a03bd4 into keylime:master Mar 23, 2022
@stefanberger stefanberger deleted the stefanberger/pylint-fix-c0115 branch March 23, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants