feat(developer): add hint when index() store is longer than any() store #12000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it does not cause any problems to have a index() store that is
longer than its corresponding any() store, it often indicates a mistake,
as the trailing characters in the store are ignored. Thus, adding as a
hint (which can be disabled via message suppression) rather than as a
warning or error.
Example code:
store(abc) 'abc'
store(defg) 'defg'
any(abc) + 'x' > index(defg, 1) c generates HINT_IndexStoreLong
Fixes: #10666
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
|
@markcsinclair you will note that I have added e2e message tests to kmc-kmn, leaving the unit test for the |
darcywong00
reviewed
Jul 24, 2024
| @@ -0,0 +1,11 @@ | |||
| store(&NAME) 'warn_index_store_short' | |||
There was a problem hiding this comment.
Suggested change
| store(&NAME) 'warn_index_store_short' | |
| store(&NAME) 'hint_index_store_short' |
darcywong00
reviewed
Jul 24, 2024
| @@ -0,0 +1,11 @@ | |||
| store(&NAME) 'warn_index_store_short_key' | |||
There was a problem hiding this comment.
Suggested change
| store(&NAME) 'warn_index_store_short_key' | |
| store(&NAME) 'hint_index_store_short_key' |
darcywong00
reviewed
Jul 24, 2024
darcywong00
reviewed
Jul 24, 2024
jahorton
approved these changes
Jul 25, 2024
mcdurdin
deleted the
feat/developer/10666-hint-on-index-store-longer-than-any
branch
|
Changes in this pull request will be available for download in Keyman version 18.0.75-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it does not cause any problems to have a index() store that is longer than its corresponding any() store, it often indicates a mistake, as the trailing characters in the store are ignored. Thus, adding as a hint (which can be disabled via message suppression) rather than as a warning or error.
Example code:
Fixes: #10666
@keymanapp-test-bot skip