Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ios): web-side sentry enablement try-catch #4492

Merged
merged 1 commit into from
Feb 22, 2021
Merged

chore(ios): web-side sentry enablement try-catch #4492

merged 1 commit into from
Feb 22, 2021

Conversation

jahorton
Copy link
Contributor

Fixes #4125.

@jahorton jahorton added this to the B14S6 milestone Feb 12, 2021
@jahorton jahorton linked an issue Feb 12, 2021 that may be closed by this pull request
chore(ios): handle situation where setSentryState is called before web page is ready #4125
Closed
@mcdurdin mcdurdin modified the milestones: B14S6, B14S7 Feb 22, 2021
mcdurdin
mcdurdin approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks acceptable.

Is it not possible to setup a retry if sentryManager is not ready? Because in those situations, we'll get no sentry reports I guess...

@jahorton jahorton merged commit 795b64e into beta Feb 22, 2021
@jahorton jahorton deleted the chore/ios/4125-sentry-enable-trycatch branch February 22, 2021 09:40
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 14.0.244-beta

@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 15.0.19-alpha

@darcywong00 darcywong00 mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

Assignees
No one assigned
Labels
chore ios/engine/ ios/
Projects
None yet
Milestone
B14S7
Development

Successfully merging this pull request may close these issues.

chore(ios): handle situation where setSentryState is called before web page is ready
3 participants
@jahorton @keyman-server @mcdurdin