Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined DEBUG for DataDirectoryIndex. #367

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Undefined DEBUG for DataDirectoryIndex. #367

wants to merge 3 commits into from

Conversation

rwindegger
Copy link

No description provided.

@aquynh
Copy link
Member

aquynh commented Aug 2, 2018 •
edited
Loading

interesting, can you please describe more on about issue?

@rwindegger
Copy link
Author

So after looking at it again I think there is more going on than I changed.

  1. I had -DDEBUG required by one of the other dependencies for some debug output. That led to a build error in that line.

  2. I just saw that LLVM defines a Macro for DEBUG as well. I think that macro is broken after that change is included. As DEBUG is undefined and redefined with a wrong value in that case. That case also does not trigger the compile error as in that case DEBUG is defined as DEBUG(X) see

    keystone/llvm/include/llvm/Support/Debug.h

    Line 85 in 0ab2b81

    #define DEBUG(X) DEBUG_WITH_TYPE(DEBUG_TYPE, X)

@aquynh
Copy link
Member

aquynh commented Dec 27, 2018

why do you disable fuzz?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwindegger @aquynh