Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jshints #857

Merged
merged 2 commits into from
Jan 5, 2015
Merged

Fix jshints #857

merged 2 commits into from
Jan 5, 2015

Conversation

morenoh149
Copy link
Contributor

Fixed most jsxhint warnings. Added 'Keystone' to jshintrc globals list. Added bootstrap-markdown.js and bootstrap-colorpicker.js to jshintignore list. Changed extensions of most fieldtypes from .js to .jsx.

…t. Added bootstrap-markdown.js and bootstrap-colorpicker.js to jshintignore list. Changed extensions of most fieldtypes from .js to .jsx.
@morenoh149 morenoh149 changed the title fixed most jsxhint warnings. Added 'Keystone' to jshintrc globals list. ... Fix jshints Jan 5, 2015
@sebmck
Copy link
Contributor

sebmck commented Jan 5, 2015

-1 to renaming .js to .jsx. See Jed's view on it here.

@JedWatson
Copy link
Member

@morenoh149 you may want to read my comments on this issue regarding using .jsx as the extension for field types: JedWatson/react-select#26

Could you roll that back for now and I'll merge the other changes?

@morenoh149
Copy link
Contributor Author

sure thing

@JedWatson
Copy link
Member

Cheers @morenoh149

JedWatson added a commit that referenced this pull request Jan 5, 2015
@JedWatson JedWatson merged commit 6804c64 into keystonejs:master Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants