Add "prop drawer" #3137
Add "prop drawer" #3137
Conversation
💥 No ChangesetLatest commit: 95a6fd4 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
|
It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue. |
| @@ -66,9 +66,9 @@ | |||
| "react-dom": "^16.13.1", | |||
| "react-select": "^3.1.0", | |||
| "react-toast-notifications": "^2.3.0", | |||
| "slate": "^0.47.4", | |||
| "slate": "^0.58.1", | |||
There was a problem hiding this comment.
FYI I've specifically left this out of my commits for now, just to hilight the problem merging in a PR that updates slate without allowing different versions between packages
There was a problem hiding this comment.
Does this supersede #2510 ?
I'm sure there is a simpler way to capture all selection changes and re-render the currently combining useEffect and some KeyUp events on the editor. Slate docs seem to have no standard way. Not sure why the BlockButtons always seem to re-render with selection changes.