Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dedicated quantity column like dnd5e default sheets and a5e sheets #99

Closed
kgar opened this issue Nov 30, 2023 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@kgar
Copy link
Owner

kgar commented Nov 30, 2023

Level Up: Advance 5e sheets have a quantity column that sits to the left of their "Show Item Description" / "Hover Fly-out Menu" section on the far right of the table row. Users of the a5e sheets report that this setup works out really well, as it does not get in the way of the item name and also provides an instant look at the item's quantity at any moment in time, as well as the ability to edit the quantity inline.

Likewise, other users have reported that the ( 1 ) quantity approach in Tidy 5e can be an eyesore when the quantities are set to always visible. Additionally, when they're only shown on hover, knowing how many items one has at a glance is not possible.

I propose we add a quantity column in the style of a5e, on the right side of the table, just before the classic controls. This will make more sense with a hover fly-out menu for the classic controls (see: #96 ). Either way, it might be best to cut at least one column from the default columns and allow users to put columns back in via column selection (#60).

image

More recently, the default dnd5e sheets have been adding quantity:

image

image

@kgar kgar added the enhancement New feature or request label Nov 30, 2023
@kgar kgar changed the title feat: Dedicated quantity column like a5e and dnd5e vehicle sheets feat: Dedicated quantity column like dnd5e default sheets and a5e sheets Nov 30, 2023
@kgar kgar self-assigned this Mar 16, 2024
kgar added a commit that referenced this issue Mar 16, 2024
* Removed the Item Quantity show on hover setting, styles, and component.

* Added quantity to inventory tab.

* Plugged in quantity columns
@kgar kgar added the awaiting-release This is awaiting release label Mar 16, 2024
@kgar
Copy link
Owner Author

kgar commented Mar 19, 2024

Closing as completed.

@kgar kgar closed this as completed Mar 19, 2024
@kgar kgar removed the awaiting-release This is awaiting release label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant