Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 43: Populate with default subreddits #46

Merged
merged 4 commits into from
Feb 21, 2019
Merged

Issue 43: Populate with default subreddits #46

merged 4 commits into from
Feb 21, 2019

Conversation

dulithadabare
Copy link
Contributor

Populated Subreddits view with default subreddits. Added section headers

@dulithadabare dulithadabare changed the title Issue 44 : Populate with default subreddits Issue 43: Populate with default subreddits Feb 18, 2019
@dulithadabare
Changes :
7388694 
Removed refreshing of default subreddit data
Added new enum SubredditSections for subreddit sections
Removed print statements
Replaced do catch statement with try?
@dulithadabare
Add SubredditSections enum as extension
3497613 
The SubredditSections enum was only being used inside the SubredditsViewController
extension. Because of this, the enum file was deleted and the enum was added
inside the extension.
kgellci
kgellci approved these changes Feb 20, 2019
View reviewed changes
Copy link
Owner

@kgellci kgellci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! We can figure out the paging in another PR. Let me know when you get lint to pass or if you need help on that and then we can merge.

@dulithadabare
Copy link
Contributor Author

Thanks! I managed to make the lint pass. What should I do now?

@kgellci kgellci merged commit fbb0918 into kgellci:master Feb 21, 2019
@kgellci
Copy link
Owner

kgellci commented Feb 21, 2019

@dulithadabare All merged! Feel free to close out whichever issue you had. Also, please update the changelog with your change!

https://github.com/kgellci/Area51/blob/master/CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RJ-Clegg RJ-Clegg RJ-Clegg left review comments

@kgellci kgellci kgellci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dulithadabare @kgellci @RJ-Clegg