New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[review] Set the correct values in the max size of glyf instructions warning. #252

Merged

khaledhosny merged 1 commit into khaledhosny:main from the-type-founders:bs-fix-max-size-glyf-instructions-warning

Nov 17, 2022

Contributor

bramstein commented Nov 17, 2022

I have a font giving an ots warning:

WARNING: glyf: Bytecode length is bigger than maxp.maxSizeOfInstructions 4937: 4937

This confused me a little until I looked at the code. I believe the warning should be printed before the maxp value is updated.


          Set the correct values in the max size of glyf instructions warning.

a921606

khaledhosny merged commit 3ac435c into khaledhosny:main

Owner

khaledhosny commented Nov 17, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet