Error matchers #58
Merged
Error matchers #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to "match" a specific type of error, and have the error you handle be casted to that type. I'm going to do the same thing with the PR as the last PR — leave it open for a week or two to see if anyone has any feedback. This PR is additive so this will go into the 2.1 release.
Wanted to thank @elenipapanik and @kremizask, the idea is pulled from their https://github.com/Workable/swift-error-handler.
One thing I'd be open to is adding an
ifNoMatchparameter with an enum value of either.ignoreor.crashwhere.ignoreis the default.