Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The first widget should be removed from the widget tree once the animation is finished #69

Closed
NamanShergill opened this issue Dec 19, 2023 · 1 comment
Closed

The first widget should be removed from the widget tree once the animation is finished #69

NamanShergill opened this issue Dec 19, 2023 · 1 comment

Comments

@NamanShergill
Copy link
Contributor

NamanShergill commented Dec 19, 2023 •
edited
Loading

animated_theme_switcher/lib/src/theme_switching_area.dart

Lines 32 to 35 in 9b659e5

Container(
key: ValueKey('ThemeSwitchingAreaFirstChild'),
child: firstWidget,
),

Not removing it from the widget tree is not the performant approach, plus, the old widget is still visible if any scroll views are involved with a transparent background.
NamanShergill added a commit to NamanShergill/animated_theme_switcher that referenced this issue Dec 19, 2023
@NamanShergill
Fix for kherel#69
9284377
@NamanShergill
Copy link
Contributor Author

Opened a PR to not show the stack once the switching animation is finished.

kherel pushed a commit that referenced this issue Dec 19, 2023
@NamanShergill
Fix for #69 (#70)
47206aa 
#69
@kherel kherel closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kherel @NamanShergill