This repository has been archived by the owner on Jan 29, 2023. It is now read-only.
Fix base64 encoding of websocket client key and progmem support for webserver #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR and sorry for the delay as the PR is a little bit complicated and takes some time to have a look. I merging the PR now, and will publish a new release soon with your contribution noted. BR, |
|
The new AsyncWebServer_STM32 releases v1.4.0 has just been published. Your contribution has been noted in Contributions and Thanks. Looking forward to receiving more of your PRs and bug reports. Best Regards, Releases v1.4.0
|
|
Thanks for the review and merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says I've fixed a couple of things. I hope it helps. 🙂