-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Feedback Buttons on Chat #721
Merged
sabaimran
merged 10 commits into
khoj-ai:master
from
MythicalCow:feature/feedback-buttons
May 20, 2024
Merged
Add Feedback Buttons on Chat #721
sabaimran
merged 10 commits into
khoj-ai:master
from
MythicalCow:feature/feedback-buttons
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabaimran
changed the title
New Feature - Feedback Buttons on Chat
Add Feedback Buttons on Chat
Apr 24, 2024
sabaimran
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! It'll be super useful being able to collect in-app feedback. Just a few comments, but the structure is great.
sabaimran
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Rationale for Changes
This feature includes thumbs up and thumbs down buttons on Khoj's chat responses that provide automated feedback. When a thumbs up/down button is clicked, the code sends an email to team@khoj.dev with the following:
This is critical in improving Khoj's nondeterministic LLM model for a better user experience.
List of Changes
api_chat.py
(/feedback) that can be used to trigger mail sending).chat.html
routers/email.py
to handle feedback email sending via resendfeedback.html
template for a formatted email with the feedback.Demo Images