Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DOM Scripting, Add CSP to Web config pages. Disable CSP in Obsidian plugin #834

Merged
merged 6 commits into from
Jul 6, 2024
Merged

Use DOM Scripting, Add CSP to Web config pages. Disable CSP in Obsidian plugin #834

merged 6 commits into from
Jul 6, 2024

Conversation

debanjum
Copy link
Member

@debanjum debanjum commented Jun 25, 2024 •
edited
Loading

Main

  • c65bd8e Add CSP to web config pages. Load phone no. validation js, css from S3
  • 1c6bc11 Construct config page elements on Web via DOM scripting
  • 719db82 Disable CSP in Khoj Obsidian as it interferes with Obsidian functionality

Miscellaneous

  • Rate limit text to speech
  • Add listening animation to voice message in Obsidian plugin

@debanjum debanjum requested a review from sabaimran June 26, 2024 02:45
@debanjum
Add listening circle animation to speak button in Obsidian plugin
6d59ad7 
Use icon active focus as color of animation button
@debanjum
Make it optional to set the encoder, cross-encoder configs via admin UI
a353d88 
Upgrade sentence-transformer, add einops dependency for some sentence
transformer models like nomic
@debanjum
Disable CSP in Khoj Obsidian as it interferes with Obsidian functiona…
69c9e8c 
…lity

The Khoj CSP interferes with other Obsidian features and plugins as
CSP is applied page wide.

For now chat message sanitization via Dompurify should suffice.

Enable CSP when can scope it to only the Khoj Obsidian plugin.
@debanjum
Construct config page elements on Web via DOM scripting.
2f034f8 
Minimize isage of innerHTML to prevent DOM clobbering and unintended
escape by user Input
@debanjum
Add CSP to web config pages. Load phone no validation js, css from S3
b334db0
@debanjum
Ratelimit text to speech model. Validate share chat url domain
9bdb488 
- Do not log auth error message on server when Resend setup as Magic
  links for sign-in are now supported
@debanjum debanjum force-pushed the update-csp-on-web-and-obsidian branch from c65bd8e to 9bdb488 Compare July 6, 2024 13:12
@debanjum debanjum merged commit 05138cb into master Jul 6, 2024
7 checks passed
@debanjum debanjum added the maintain Maintain code, documentation or project label Jul 6, 2024
@debanjum debanjum deleted the update-csp-on-web-and-obsidian branch July 6, 2024 14:23
debanjum added a commit that referenced this pull request Jul 11, 2024
@debanjum
Add DB migration from making bi_encode configs optional in #834
cbae8b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabaimran sabaimran Awaiting requested review from sabaimran

Assignees
No one assigned
Labels
maintain Maintain code, documentation or project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@debanjum