-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get build flow cleaned up #32
Comments
For this, I'd kind of expect there to be a single layer; otherwise we're just introducing a bunch of overhead by indirecting through all the layers. The same conclusion was reached by the (now singular) validation layer. Build flags to exclude extensions from the build wouldn't be a terrible idea though. We should probably come up with a set of guidelines on how to contribute extensions (e.g. conventions they should use like how to adhere to build flags), and how to ship this layer with an application. We should also add an implementation of VK_EXT_private_data as a part of the baseline changes as well, since it's almost guaranteed we'll need that for future extensions, otherwise this wheel will simply be reinvented over and over again (maybe that should be a separate issue?). |
There are CI Linux/MacOS builds. It's based off what the validation layers have. |
The difference is the old Validation Layers made no sense by themselves. For this, I wouldn't want to force the overhead of one extension layer over the other As fo VK_EXT_private_data, there will be implementations that don't support it and that needs to be accounted for |
So basically everything I wanted out of this issue was added with the sync2 layer |
In order to improve adding more layers in the future and making sure everything works on major platforms (Windows, Linux, Android, etc) there are a few things that could be fixed
VkLayerProperties::implementationVersion
Bonus:
The text was updated successfully, but these errors were encountered: