Refactor to represent download state using Flow #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noted @PrimoDev23 thanks, I will check the PR and get back. |
|
@PrimoDev23 I have made the major update in Ketch with support of pause and resume functionality. Please feel free to check out, this version makes library more flexible with less client interactions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I just decided to give this a try, so feel free to apply that PR to your library.
This refactoring solves some issues like memory leaks that might occur when injecting an instance of Ketch.
Also I removed the DownloadManager as a state holder, since the user of the library should better take care of state handling and freeing resources.
This way the library also follows a more reactive approach.
Feel free to comment on it.