Skip to content
This repository has been archived by the owner on Feb 18, 2023. It is now read-only.

Fix issues found on x-series charts #101

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Conversation

jotak
Copy link
Collaborator

@jotak jotak commented Jul 22, 2020

Follow-up on #98

  • Fixed bar charts overlaping on left axis
  • Won't display overlay when xAxis type is series (timeless)

Follow-up on kiali#98
- Fixed bar charts overlaping on left axis
- Won't display overlay when xAxis type is series (timeless)
@jotak jotak requested a review from lucasponce July 22, 2020 14:30
@jotak jotak self-assigned this Jul 22, 2020
@jotak
Copy link
Collaborator Author

jotak commented Jul 22, 2020

@lucasponce this fixes the comments you had.
Now bars are more centered to prevent them overlapping over left axis:

Capture d’écran de 2020-07-22 16-29-09

@lucasponce
Copy link
Contributor

On my screen I get these ones:

  • x-series with bars looks ok:
    image

-x-series with scatters looks weird when it touches the x-axis, but nothing to change IMO:
image

But I see a couple of minor issues that also found in Kiali and are a little bit annoying:

  • Empty logo should be centered:
    image

  • Same happens on error cases:
    image

On wide screens it's more visible, perhaps in a standard view it looks horizontally centered, but I guess on empty/errors, that element could be centered with the available width.

In Kiali with the two columns of charts, it's more visible and empty logos look strange, I think.

@jotak
Copy link
Collaborator Author

jotak commented Jul 24, 2020

Thanks. I'll merge it, the issue on error/empty is really unrelated, i'll investigate apart.

@jotak jotak merged commit 832419d into kiali:master Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants