This repository has been archived by the owner on Feb 18, 2023. It is now read-only.
Adding more tests (see KIALI-3069) #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests to make sure we never produce nil-slices before json serialization
jshaughn
approved these changes
Jun 27, 2019
There was a problem hiding this comment.
LGTM. I have to assume that this problem was due to some temporary mismatch or dependency issue in the UI build. I can not get it to reproduce after ensuring yarn had pulled in the correct dependencies and server/ui were both up to date and built clean, and that my kiali container pod contained my latest ui build. I tested also using yarn start and it was also fine. I think with this commit we can close the Jira.
|
Thanks @jshaughn , I'm merging this anyway, but we can wait for @josejulio to see if he still reproduces before closing the jira |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to make sure we never produce nil-slices before json serialization
See comments in https://issues.jboss.org/browse/KIALI-3069