This repository has been archived by the owner on Feb 18, 2023. It is now read-only.
onClick hook: find closest datapoint #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Travis build: go 1.12 and node 12 - Update pf versions to match kiali-ui
- Need to get clicked coords relative to SVG - Need to normalize distance (in closest-point algorithm) relatively to domain amplitude
|
@aljesusg I've pushed some changes, it seems to work correctly now with your PR |
lucasponce
reviewed
Dec 19, 2019
| .add('as scatter plots with dates', () => { | ||
| return <ChartWithLegend data={[tracesXAsDates]} unit="seconds" seriesComponent={(<ChartScatter/>)} onClick={dp => alert(`${dp.name}: [${dp.x}, ${dp.y}]`)} />; | ||
| }) | ||
| .add('with two series', () => { |
lucasponce
approved these changes
Dec 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New algorithm to find closest dp; Added stories & tests
Closes kiali/kiali#2039