Skip to content
This repository has been archived by the owner on Feb 18, 2023. It is now read-only.

Update go dependencies (k8s 1.14.6, prom 0.9.4) #86

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Update go dependencies (k8s 1.14.6, prom 0.9.4) #86

merged 1 commit into from
Apr 7, 2020

Conversation

jotak
Copy link
Collaborator

@jotak jotak commented Apr 7, 2020

This is to align k-charted go dependencies with the ones of Kiali, to avoid a couple of warnings during deps update.

@jotak jotak mentioned this pull request Apr 7, 2020
Merged
@aljesusg
Copy link
Contributor

aljesusg commented Apr 7, 2020

ok let me test is there is any error

aljesusg
aljesusg approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@aljesusg aljesusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@jotak
Copy link
Collaborator Author

jotak commented Apr 7, 2020

thanks @aljesusg

@jotak jotak merged commit e7fab0c into kiali:master Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aljesusg aljesusg aljesusg approved these changes

@lucasponce lucasponce Awaiting requested review from lucasponce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jotak @aljesusg