Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new custom headers setting to tracing config #769

Merged
merged 1 commit into from
May 22, 2024
Merged

add new custom headers setting to tracing config #769

merged 1 commit into from
May 22, 2024

Conversation

jmazzitelli
Copy link
Contributor

Supports custom headers for tracing backend requests

part of: kiali/kiali#7266

@jmazzitelli jmazzitelli self-assigned this May 13, 2024
@jmazzitelli jmazzitelli marked this pull request as ready for review May 14, 2024 19:13
@jmazzitelli jmazzitelli added the requires server PR A PR requires additional changes in the backend code. label May 15, 2024
@jmazzitelli jmazzitelli requested a review from josunect May 17, 2024 21:06
jshaughn
jshaughn approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run it because the community originator of the RFE already tested it successfully. Code looks good for me.

@jshaughn jshaughn added the test: molecule Molecule test infrastructure and tests themselves label May 22, 2024
@jmazzitelli jmazzitelli merged commit 8e7f760 into kiali:master May 22, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the 7266-custom-headers-tracing branch May 22, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

@josunect josunect Awaiting requested review from josunect

Assignees

@jmazzitelli jmazzitelli

Labels
requires server PR A PR requires additional changes in the backend code. test: molecule Molecule test infrastructure and tests themselves
Projects
Kiali Sprint 24-14 | Kiali v2.1
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmazzitelli @jshaughn