Improve Install via Helm. #765
Conversation
There was a problem hiding this comment.
This is OK. The reason we did not specify anonymous setting before is because this will open up the Kiali UI to anyone. So it isn't secure. Because of this, just add a blurb at the end to call this out to the reader so they are aware running that command is not secure, and if they want to make it secure, there are options to do so. See my suggestion (make sure that link works :).
content/en/docs/Installation/installation-guide/install-with-helm.md
Outdated
Show resolved
Hide resolved
|
The netlify link to go to in order to see the change is found here: https://deploy-preview-765--kiali.netlify.app/docs/installation/installation-guide/install-with-helm/#install-with-operator |
Co-authored-by: John Mazzitelli <mazz@redhat.com>
There was a problem hiding this comment.
Check the netlify page - https://deploy-preview-765--kiali.netlify.app/docs/installation/installation-guide/install-with-helm/#install-with-operator
As I suspected ("See my suggestion (make sure that link works :)") , the link doesn't work :) I think you need to prefix it with /doc. So /doc/configuration/authentication/.
| @@ -69,6 +69,7 @@ command: | |||
| $ helm install \ | |||
| --set cr.create=true \ | |||
| --set cr.namespace=istio-system \ | |||
| --set cr.auth.strategy="anonymous" \ | |||
There was a problem hiding this comment.
This is my fault. I did not properly review this PR.
This is wrong and does nothing to affect the strategy. It should have been:
--set cr.spec.auth.strategy="anonymous" \
(note the missing .spec)
| the Kiali operator starts, it will process it to deploy Kiali. After Kiali has started, | ||
| you can access Kiali UI through 'http://localhost:20001' by executing | ||
| `kubectl port-forward service/kiali -n istio-system 20001:20001` | ||
| because of `--set cr.auth.strategy="anonymous"`. But realize that anonymous mode will allow anyone to be able to see and use Kiali. If you wish to require users to authenticate themselves by logging into Kiali, use one of the other [auth strategies](/docs/configuration/authentication/). |
There was a problem hiding this comment.
and here, too - should be "cr.spec.auth.strategy"
There was a problem hiding this comment.
@jmazzitelli sorry to bother you.
you right, i missed it. I'm really sorry.
From this, as you said, cr.auth.strategy="anonymous" should be change to cr.spec.auth.strategy="anonymous", i think.
May i create new PR to fix it?
There was a problem hiding this comment.
I already corrected it. It's live on the site: https://kiali.io/docs/installation/installation-guide/install-with-helm/#install-with-operator
There was a problem hiding this comment.
I see.
Thanks for your help. 🙇♂️
Background
Hi, I'm new in
kialiand this is my first PR!When I first tried to install the
Kialioperator and access theKiali UI, I encountered a problem where the token could not be found, and it was difficult to find a solution through searching the documentation.The problem occurred with the commands below.
$ helm install \ --set cr.create=true \ --set cr.namespace=istio-system \ --namespace kiali-operator \ --create-namespace \ kiali-operator \ kiali/kiali-operatorThus, IMO, it will be better to add
--set cr.auth.strategy="anonymous"for newbie inkialito started withkialieasily.Changes
--set cr.auth.strategy="anonymous"to install via helm page.