KIBA-1774: Create a DiscordClient and use in MessageProcessor #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishan711
changed the title
krishan711
reviewed
May 10, 2023
CHANGELOG.md
Outdated
| @@ -8,6 +8,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| - [MAJOR] Added `notification_client.py` abstract class to help send data to multiple platforms | |||
There was a problem hiding this comment.
Suggested change
| - [MAJOR] Added `notification_client.py` abstract class to help send data to multiple platforms | |
| - [MAJOR] Added `NotificationClient` abstract class to help send data to multiple platforms |
krishan711
reviewed
May 10, 2023
CHANGELOG.md
Outdated
| @@ -8,6 +8,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| - [MAJOR] Added `notification_client.py` abstract class to help send data to multiple platforms | |||
| - [MAJOR] Added `discord_client.py` to send data discord server | |||
There was a problem hiding this comment.
Suggested change
| - [MAJOR] Added `discord_client.py` to send data discord server | |
| - [MAJOR] Added `DiscordClient` to send data discord server |
krishan711
reviewed
May 10, 2023
CHANGELOG.md
Outdated
| @@ -8,6 +8,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| - [MAJOR] Added `notification_client.py` abstract class to help send data to multiple platforms | |||
| - [MAJOR] Added `discord_client.py` to send data discord server | |||
| - [MINOR] Updated `MessageQueueProcessor` to use a list of NotificationClients to send server messages | |||
There was a problem hiding this comment.
Suggested change
| - [MINOR] Updated `MessageQueueProcessor` to use a list of NotificationClients to send server messages | |
| - [MINOR] Updated `MessageQueueProcessor` to use a list of `NotificationClients` to send server messages |
krishan711
reviewed
May 10, 2023
| @@ -13,8 +14,9 @@ | |||
| from core.exceptions import KibaException | |||
| from core.queues.message_queue import MessageQueue | |||
| from core.queues.model import Message | |||
| from core.slack_client import SlackClient | |||
| # from core.slack_client import SlackClient | |||
krishan711
reviewed
May 10, 2023
krishan711
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots:
Checklist: