NT-1432 && NT-1466: Update gradle plugin && Update apollo library #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkariang
changed the title
| @@ -24,6 +24,7 @@ import com.kickstarter.ui.fragments.BackingAddOnsFragment | |||
| import rx.Observable | |||
| import rx.subjects.BehaviorSubject | |||
| import rx.subjects.PublishSubject | |||
| import java.util.* | |||
There was a problem hiding this comment.
nit: Why was this import added? Is it possible to not use the wild card and instead list each import individually? I just think it's easier for readability.
leighdouglas
approved these changes
Oct 30, 2020
| @@ -20,6 +20,7 @@ import com.kickstarter.ui.fragments.RewardsFragment | |||
| import rx.Observable | |||
| import rx.subjects.BehaviorSubject | |||
| import rx.subjects.PublishSubject | |||
| import java.util.* | |||
There was a problem hiding this comment.
nit: same here as comment above
Arkariang
changed the title
Arkariang
deleted the
imartin/NT-1432-update-gradle-NT-1466-update-apollo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
📋 QA
./bin/milkrun update-strings.bundle exec fastlane internal.bundle exec fastlane externalStory 📖
NT-1466
NT-1432