Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NT-1653: Create account flow #1037

Merged
merged 4 commits into from
Nov 10, 2020
Merged

NT-1653: Create account flow #1037

merged 4 commits into from
Nov 10, 2020

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Present Interstitial Screen on CreationAccount flow

🛠 How

  • Adde new method in LoginHelper.kt showInterstitialFragment(supportFragmentManager: FragmentManager, user: User, loginViewId: Int)
  • Added new output to present the Interstitial screen on SignUpViewModel.java
  • new tests

👀 See

creation_account_flow

| | |

📋 QA

  • Create account with feature flag enabled presents the Interstitial screen
  • Create account with feature flag disabled do not present Interstitial screen and let's you continue flow.

Story 📖

NT-1653

@Arkariang Arkariang marked this pull request as ready for review November 9, 2020 23:18
@Arkariang Arkariang changed the title NT-1653 create account flow NT-1653: Create account flow Nov 10, 2020
leighdouglas
leighdouglas approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

@Arkariang Arkariang merged commit 8d01e78 into master Nov 10, 2020
@Arkariang Arkariang deleted the imartin/NT-1653-create-account-flow branch November 10, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

Assignees
No one assigned
Labels
feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkariang @leighdouglas