Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NT-1595: Creator view adjustments #1041

Merged
merged 4 commits into from
Nov 25, 2020
Merged

NT-1595: Creator view adjustments #1041

merged 4 commits into from
Nov 25, 2020

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Visual tweecks for the View Pledge screen, creator and backer perspective

👀 See

| Before 🐛 | After 🦋 |

  • The title of the creator View Pledge screen reads “View pledge”
  • The title of the reward is shown in the reward card

CREATOR-Perspective

  • The estimated delivery date of the reward is shown above the reward card when no reward in Backer perspective

BACKERNoReward-BackerPerspective

| --- | --- |
| | |

📋 QA

  • For the first two points log as a creator, go to a message from a backer and press the view pledge button on the ThreadMessages screen
  • For the last point pledge to any reward no reward, the go to the view pledge screen

Story 📖

Android creator view pledge adjustments

@Arkariang Arkariang marked this pull request as ready for review November 19, 2020 00:39
Arkariang
Arkariang commented Nov 19, 2020
View reviewed changes
app/src/main/java/com/kickstarter/ui/fragments/BackingFragment.kt
@@ -65,8 +67,10 @@ class BackingFragment : BaseFragment<BackingFragmentViewModel.ViewModel>() {
.subscribe { setBackerImageView(it) }

this.viewModel.outputs.backerName()
.observeOn(io())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes for this subscription are related to this -> https://console.firebase.google.com/u/1/project/android-external-release/crashlytics/app/android:com.kickstarter.kickstarter/issues/310732673fa17a383580c28e897e2993?time=last-seven-days&versions=2.11.0%20(2011121700)&sessionEventKey=5FB659DF012C00017CA8F31D71F5CF52_1475252020298250304

leighdouglas
leighdouglas approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Arkariang Arkariang merged commit 4e002f3 into master Nov 25, 2020
@Arkariang Arkariang deleted the imartin/NT-1595-creator-view-adjustments branch November 25, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

Assignees
No one assigned
Labels
bug 🐛 refactor 🛠
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkariang @leighdouglas