Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
butterknife
dependency for this Activity.🤔 Why
ActualTop first occurring crash, not able to reproduce locally, but here you can see with more detail the stacktrace.
The stacktrace suggest the crash happens when the method
.handleProjectUpdateUriRequest
is called before the activity lifecycle
onCreate
method or afteronDestroy
method, the only moments in which the ViewModel.inputs can be null, so we are tacking the change to migrate this class from Java to kotlin and protect against NullPointerExceptions using Kotlin optionals. Also deleting all references in this activity to thebutterknife
dependency.👀 See
| | |
📋 QA
Story 📖
NT-1707