Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1707: Update Activity crash #1059

Merged
merged 3 commits into from
Dec 9, 2020

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Minimize the top most crash we are currently suffering
  • Migrate the UpdateActivity.java to kotlin, and protect any method susceptible of being called outside of the lifecycle context.
  • Delete any code related with the butterknife dependency for this Activity.

🤔 Why

ActualTop first occurring crash, not able to reproduce locally, but here you can see with more detail the stacktrace.

The stacktrace suggest the crash happens when the method
.handleProjectUpdateUriRequest

is called before the activity lifecycle onCreate method or after onDestroy method, the only moments in which the ViewModel.inputs can be null, so we are tacking the change to migrate this class from Java to kotlin and protect against NullPointerExceptions using Kotlin optionals. Also deleting all references in this activity to the butterknife dependency.

👀 See

migration_update_activity

| | |

📋 QA

  • Open the Update activity screen, load some updates for projects from that activity, interact with some of the updates (like, comment, share ...).
  • Open the Update activity screen, open the project page from some project

Story 📖

NT-1707

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!! 🎉

@Arkariang Arkariang merged commit bc694e3 into master Dec 9, 2020
@Arkariang Arkariang deleted the imartin/NT-1707-update-activity-crash branch December 9, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants