Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1766:Add firebase In-App Messaging #1100

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Feb 12, 2021

📲 What

integrate firebase in-app messaging to app

🤔 Why

To be able to communicate with app and send the in-app message in case user disable notification

🛠 How

Add firebase in-app messaging dependencies to the app
Use the firebase in-app messaging Picasso version to remove Picasso dependence and update code

👀 See

image

Before 🐛 After 🦋

📋 QA

Test Screen that shows images

Story 📖

https://kickstarter.atlassian.net/browse/NT-1766

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! great work @hadia

@Arkariang
Copy link
Contributor

Feel free to merge once the checkstyle is fixed 👍

@hadia hadia merged commit cd93930 into master Feb 16, 2021
@hadia hadia deleted the hadia/firebase_in_app_message branch February 16, 2021 16:58
hadia added a commit that referenced this pull request Feb 18, 2021
…1104)

* NT-1766:Add firebase In-App Messaging (#1100)

* Remove picasso and use version that in app messaging api

* Refactor
Picasso.with(context())
to Picasso.get()

* incorrect indentation Fixed

* Replace Picasso.with(context) with Picasso.get() due to use higher version in firebase in-app sdk integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants