Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP-335: Page Viewed (sign_up) #1168

Merged
merged 4 commits into from
Mar 17, 2021

Conversation

sunday-okpoluaefe
Copy link
Contributor

📲 What

Android: Page Viewed (sign_up)

🤔 Why

Segment Implementation

🛠 How

  • Created new method trackSignUpPageViewed in AnalyticEvents
/**
     * Tracks sign-up page viewed.
     */
    fun trackSignUpPageViewed() {
        val props: HashMap<String, Any> = hashMapOf(CONTEXT_PAGE.contextName to SIGN_UP.contextName)
        client.track(PAGE_VIEWED.eventName, props)
    }

  • Called method from SignUpViewModel on page initialised
...
  this.lake.trackSignUpPageViewed();
...
    

👀 See

Screenshot 2021-03-17 at 13 07 20

Before 🐛 After 🦋

📋 QA

  • Visit the Sign Up screen, you should see the new event registered in the segment console

Screenshot 2021-03-17 at 13 07 28

Story 📖

https://kickstarter.atlassian.net/browse/EP-335

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sunday-okpoluaefe sunday-okpoluaefe merged commit 857cf6e into master Mar 17, 2021
@sunday-okpoluaefe sunday-okpoluaefe deleted the sunday/EP-335-sign-up-page-viewed branch March 17, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants