Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP-263: Android: Video Playback Completed #1174

Merged
merged 7 commits into from
Mar 22, 2021
Merged

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 19, 2021

📲 What

add Video Playback Completed segment event

🤔 Why

A user clicks finished viewing video event or press back

🛠 How

Add Event Handler in Video ViewModel
image

Add test
image
image

👀 See

image

📋 QA

open Project and click the video Play button and press back

Story 📖

https://kickstarter.atlassian.net/browse/EP-263

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hadia hadia merged commit 2fdd2f2 into master Mar 22, 2021
@hadia hadia deleted the hadia/video_completed_event branch March 22, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants