Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] EP-389: Phase 1 QA Feedback Priority 1 properties #1180

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Mar 24, 2021

📲 What

  • Updated session_current_variants -> session_variants_internal
  • Added user_backed_projects_count to user properties
  • Added user_launched_projects_count to user properties
  • Updated currentVariants to return an array instead of a string
  • Updated the SegmentTest and LakeTest class

🤔 Why

Segment integration.

🛠 How

  • Updated the property session_current_variants in the sessionProperties() function in the TrackingClient class, and updated the method that is populating this field to return an array instead of a string. Updated the tests for this new logic as well.
  • Created the property user_backed_projects_count in the userProperties() function in the AnalyticEventsUtils ext
  • Created the property user_launched_projects_count in the userProperties() function in the AnalyticEventsUtils ext
  • Updated all tests in the SegmentTestClass that are calling an event where user properties would be sent

📋 QA

  • To test this, you should fire off an event in the android app and see that the correct property is in segment.
  • The user properties will only fire when the user is logged in

Example:

  • Open App and login if necessary, make sure the account you are using has backed AND launched projects
  • Tap on a project
  • In segment, you should see the "Page Viewed" event with context_page = project. You should also see the following properties:
    Screen Shot 2021-03-24 at 4 02 15 PM

The raw JSON for this property should look like this:
Screen Shot 2021-03-24 at 4 02 26 PM

Story 📖

EP-389: [Android] Create Properties: Phase 1 QA Feedback Priority 1

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉👌

@leighdouglas leighdouglas merged commit 41825e0 into master Mar 24, 2021
@leighdouglas leighdouglas deleted the leigh/ep-389-qa-p1 branch March 24, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants