NT-1821: Switch prelaunch display logic to use display_prelaunch field from v1 API #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighdouglas
changed the title
leighdouglas
added a commit
that referenced
this pull request
Apr 14, 2021
…d from v1 API (#1205) * Replace prelaunchActivated with displayPrelaunch * Update tests and project factory
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Switch logic tied to
prelaunchActivated()from theUserpayload to rely ondisplayPrelaunch()instead.🤔 Why
Currently, native is using the field
prelaunch_activatedto determine the display logic of prelaunch deeplinks. We want to change this logic to checkdisplay_prelaunchinstead.The backend will be updating
prelaunch_activatedto actually return the correctproject.prelaunch_activatedvalue. This is also keeping parity with web as they are using this field. Because of this, any instances using prelaunch_activated for display logic will need to be updated to use display_prelaunch instead.Relevant backend PR: https://github.com/kickstarter/kickstarter/pull/21408
🛠 How
Userstruct to grabdisplayPrelaunchvalue available from the APIprelaunchActivated()todisplayPrelaunch()so logic relys on this booleanProjectFactorymethodprelaunchProjectto be set thedisplayPrelaunchvalue📋 QA
This change requires smoke and regression testing.
Story 📖
NT-1821: Switch prelaunch display logic to use display_prelaunch field from v1 API