EP-421/Android: CTA Clicked (project) #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadia
changed the title
# Conflicts: # app/src/main/java/com/kickstarter/libs/AnalyticEvents.kt # app/src/test/java/com/kickstarter/libs/SegmentTest.kt
| @@ -749,6 +751,27 @@ class AnalyticEvents(trackingClients: List<TrackingClientType?>) { | |||
| client.track(CTA_CLICKED.eventName, props) | |||
| } | |||
|
|
|||
| /** | |||
| * Tracks a discover project clicks on the search result. | |||
There was a problem hiding this comment.
Please add parameter documentation to this
| /** | ||
| * Tracks a discover project clicks on the search result. | ||
| */ | ||
| fun trackDiscoverSearchResultProjectCATClicked( |
There was a problem hiding this comment.
please correct the spelling of this method -> trackDiscoverSearchResultProjectCTAClicked
leighdouglas
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
send CTA Clicked (project)User taps on a project from the results on the search page.
🤔 Why
🛠 How
👀 See
📋 QA
the open project as a search result
Story 📖
https://kickstarter.atlassian.net/browse/EP-421