Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP-488: Android QA Project Subcategory & Tags #1217

Merged
merged 5 commits into from
Apr 22, 2021

Conversation

leighdouglas
Copy link
Contributor

📲 What

This ticket addresses the following properties:

  • project_subcatergory was previously sending the localized name of the subcategory. This PR updates this to send the subcategory name in english
  • project_tags were not previously being sent, so the project model and project properties have been updated to send this value

🤔 Why

Segment Integration/QA Feedback

🛠 How

For project_subcategory, the v1 api was updated to include a new field, analyticsName, with the category model, which includes the non-localized subcategory name (backend PR: https://github.com/kickstarter/kickstarter/pull/21281)
For project_tags, the backend exposed a field to return the public tags for a given project. We updated the project struct and now are sending the tags as a string delineated by the comma.

📋 QA

project_subcategory:

  • Change your device language to something other than English
  • Open the app
  • Tap the hamburger menu
  • Tap on a category, for example "Games"
  • Tap on a subcategory, for example "Tabletop Games"
  • Tap on a project card
  • In segment, you should see the subcategory name in english, not localized

project_tags:

  • Open the app
  • Tap on a project card on the discover screen
  • In segment, a list of project tags as a string delineated by a comma
    📣 Note that project tags are not currently available for all events, as the payload for projects we receive from the backend differs depending on where we are in the app 📣

Screen Shot 2021-04-21 at 2 36 24 PM

Story 📖

EP-488: Android QA Project Subcategory & Tags

Copy link
Contributor

@sunday-okpoluaefe sunday-okpoluaefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job

@leighdouglas leighdouglas merged commit 8edc1a8 into master Apr 22, 2021
@leighdouglas leighdouglas deleted the leigh/ep-488-project-category branch April 22, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants