NT-1735: Target API 30 🚀 #1240
Merged
NT-1735: Target API 30 🚀 #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 444d1b6.
leighdouglas
force-pushed
the
feature/adopt-api-30
branch
from
9a36b18
to
38b5bf9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1240 +/- ##
============================================
- Coverage 74.85% 74.69% -0.16%
+ Complexity 738 734 -4
============================================
Files 221 221
Lines 6645 6656 +11
Branches 402 402
============================================
- Hits 4974 4972 -2
- Misses 1538 1551 +13
Partials 133 133
Continue to review full report at Codecov.
|
Arkariang
reviewed
May 11, 2021
| @@ -49,7 +51,13 @@ abstract class KSRobolectricTestCase : TestCase() { | |||
| .applicationModule(TestApplicationModule(application())) | |||
| .build() | |||
|
|
|||
| val config = ConfigFactory.config().toBuilder() | |||
Arkariang
reviewed
May 11, 2021
| @@ -23,13 +23,13 @@ | |||
| @Before | |||
| public void setUp() { | |||
| RxAndroidPlugins.getInstance().reset(); | |||
| ShadowLooper.pauseMainLooper(); | |||
| //ShadowLooper.pauseLooper(Looper.myLooper()); | |||
There was a problem hiding this comment.
delete this two lines please
Arkariang
approved these changes
May 11, 2021
Arkariang
reviewed
May 11, 2021
| @@ -94,6 +96,7 @@ class BackingFragmentViewModelTest : KSRobolectricTestCase() { | |||
| this.vm.outputs.projectDataAndAddOns().subscribe(this.listAddOns) | |||
| this.vm.outputs.bonusSupport().map { it.toString() }.subscribe(this.bonusAmount) | |||
| this.vm.outputs.deliveryDisclaimerSectionIsGone().subscribe(this.disclaimerSectionIsGone) | |||
| Shadows.shadowOf(Looper.getMainLooper()).idle() | |||
There was a problem hiding this comment.
I think these Shadows.shadowOf(Looper.getMainLooper()).idle() are no longer necessary as you found the root cause if blocking problem
There was a problem hiding this comment.
Okay i can remove them and see if it passes CI
There was a problem hiding this comment.
Done, and everything passed CI! 🎉 🚀
leighdouglas
changed the title
leighdouglas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Upgrading to Android API 30 requires a few updates for our codebase to be compatible. I have added a queries element to the Android manifest file for the new package visibility requirements in API 30. Also updated tests to reflect new formatting changes.
ObserveForUITransformerTestsuite (more on that below)🛠 How
More context on
ObserveForUITransformerTest-> Robolectric 4.4 was a massive update that included changes to their shadow looper. These changes are causing mysterious test failures during thetearDown()that happens after the test is run, specifically it is throwing anjava.lang.UnsupportedOperationException: main looper cannot be unpausedexception. After exhausting a few solutions from their documentation (they have a whole article about it here-> http://robolectric.org/blog/2019/06/04/paused-looper/), and since all of this code is about 5 years old, @jgsamudio and I decided to remove these lines since the tests are passing without them. Perhaps robolectric is not performing these operations for us under the hood.For the jacoco config to exclude generating coverage for jvm internal classes, this is a known issue and related to our target jvm being 1.8. See -> gradle/gradle#5184
👀 See
No UI changes
📋 QA
Since these are all internal changes and not user facing, I would test this by opening the app and making sure nothing is crashing.
Story 📖
[SPIKE] Fix Test Environment for Android 11 Migration
[Spike]Android 11: Target API 30