Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1825:Automatic release process step 2 #1248

Merged
merged 9 commits into from
May 18, 2021

Conversation

Arkariang
Copy link
Contributor

📲 What

  • The APK that was generated on our CI workflow was using an invalid sign in credentials, resulting in this error when trying to upload that apk to the play store
    error

  • For the release workflow the field "Release notes" on firebase will hold the version name.

🛠 How

  • When on build.gradle we now check some environment configurations when providing the release configs.

👀 See

| Before 🐛 | After 🦋 |
before-now

  • Release APK on firebase will have on the "Release notes" field the version name
    Firebase

  • Both pipelines on the public CI environment and private CI environment ends successfully
    publicCIenv
    privateCIenv

| | |

📋 QA

  • Cut a release branch, sit and enjoy
  • Once the private CI environment has finalized it's work you'll be able to release on google play the latest apk available on firebase on the release lane

Story 📖

NT-1825

@Arkariang Arkariang marked this pull request as ready for review May 17, 2021 19:18
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1248 (69e0517) into master (7766d1b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1248   +/-   ##
=========================================
  Coverage     74.76%   74.76%           
  Complexity      740      740           
=========================================
  Files           222      222           
  Lines          6697     6697           
  Branches        411      411           
=========================================
  Hits           5007     5007           
  Misses         1552     1552           
  Partials        138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7766d1b...69e0517. Read the comment docs.

Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

@Arkariang Arkariang merged commit aa0a6c4 into master May 18, 2021
@Arkariang Arkariang deleted the imartin/NT-1825-automatic-release-process branch May 18, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants