Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2038: Cell UI for pagination error & NT-2039: Reload the errored page #1290

Merged
merged 3 commits into from
Jun 15, 2021

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Jun 14, 2021

📲 What

  • Added pagination Error cell ViewHolder + ViewModel + ViewHolderViewModelTest
  • Retry errorred page callback

👀 See

retry-errored-page.mp4

| | |

📋 QA

  • Load a project with several comments -> Load coments screen - Lose conectivity -> scroll to the bottom -> once the loading indicator has finished you'll see a new cell on the bottom with the error displayed -> touch the cell or pull the bottom of the list -> recover conectivity -> touch the cell or pull the bottom of the list -> you will see the next page loaded on the list and the error cell disappear

Story 📖

NT-2019

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #1290 (dc6bd68) into master (b234fe2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1290   +/-   ##
=========================================
  Coverage     74.34%   74.34%           
  Complexity      739      739           
=========================================
  Files           221      221           
  Lines          6646     6646           
  Branches        405      405           
=========================================
  Hits           4941     4941           
  Misses         1569     1569           
  Partials        136      136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b234fe2...dc6bd68. Read the comment docs.

@Arkariang Arkariang changed the title NT-2038: Cell UI for pagination error NT-2038: Cell UI for pagination error & NT-2039: Reload the errored page Jun 14, 2021
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌🎉

@Arkariang Arkariang merged commit a5648a9 into master Jun 15, 2021
@Arkariang Arkariang deleted the imartin/NT-2038-CellUI-for-pagination-error branch June 15, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants