Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2055: Duplicated comments #1293

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Jun 15, 2021

📲 What

  • Bug that duplicated comments
  • Bug when trying to post to a project without any previous comment

👀 See

noMoreDuplicated.mp4

| | |

📋 QA

  • Bug 1 when going background after posting
    Screen Shot 2021-06-15 at 4 45 49 PM

  • Bug 2
    Look for a project without comments, make the first comment, it should not crash, and it should post the comments successfully.

Story 📖

NT-2055

@Arkariang Arkariang changed the title https://kickstarter.atlassian.net/browse/NT-2055 NT-2055: Duplicated comments Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #1293 (8652dbc) into master (7820d79) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1293   +/-   ##
=========================================
  Coverage     74.34%   74.34%           
  Complexity      739      739           
=========================================
  Files           221      221           
  Lines          6646     6646           
  Branches        405      405           
=========================================
  Hits           4941     4941           
  Misses         1569     1569           
  Partials        136      136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7820d79...8652dbc. Read the comment docs.

@Arkariang Arkariang marked this pull request as ready for review June 16, 2021 00:28
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀 we should add tests in a subsequent PR, but I understand that this is needed for release so approved!

@Arkariang Arkariang merged commit e074b4b into master Jun 16, 2021
@Arkariang Arkariang deleted the imartin/post-duplicated-when-background branch June 16, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants