Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Reply" copy #1294

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Fix "Reply" copy #1294

merged 1 commit into from
Jun 16, 2021

Conversation

leighdouglas
Copy link
Contributor

📲 What

We were displaying the wrong copy for the "Reply" button on the comment card. This updates to use the correct string.

👀 See

English and Spanish translations for reply, as examples:

Screenshot_1623862463 Screenshot_1623862500

📋 QA

Go to the comments page on a project you have backed and check to make sure the Reply button is spelled correctly. Change device language to another language (Spanish or german for example) and recheck the comments page to make sure the correct translation is being used.

@leighdouglas leighdouglas requested review from hadia, Arkariang and sunday-okpoluaefe and removed request for hadia and Arkariang June 16, 2021 16:59
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm!

@Arkariang Arkariang self-requested a review June 16, 2021 17:04
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #1294 (4994270) into master (e074b4b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1294   +/-   ##
=========================================
  Coverage     74.34%   74.34%           
  Complexity      739      739           
=========================================
  Files           221      221           
  Lines          6646     6646           
  Branches        405      405           
=========================================
  Hits           4941     4941           
  Misses         1569     1569           
  Partials        136      136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e074b4b...4994270. Read the comment docs.

@leighdouglas leighdouglas merged commit d291935 into master Jun 16, 2021
@leighdouglas leighdouglas deleted the leigh/correct-reply-string branch June 16, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants