Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2044: UI – Handle long translations for fail to post error message #1295

Merged

Conversation

sunday-okpoluaefe
Copy link
Contributor

πŸ“² What

UI – Handle long translations for fail to post error message

πŸ€” Why

  • We should maintain the border size there – the distance between the end of the text and the grey separator.

πŸ›  How

  • Added top constraints to icon

πŸ‘€ See

| Before πŸ›
Screenshot_20210611-092337_Kickstarter (1)

| After πŸ¦‹ |
error_margin

πŸ“‹ QA

  • Go to any backed project
  • Select comments
  • Changed device language to Spanish
  • Disable network connection.
  • Post a new comment

Story πŸ“–

https://kickstarter.atlassian.net/browse/NT-2044

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #1295 (2c3a583) into master (d291935) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1295   +/-   ##
=========================================
  Coverage     74.34%   74.34%           
  Complexity      739      739           
=========================================
  Files           221      221           
  Lines          6646     6646           
  Branches        405      405           
=========================================
  Hits           4941     4941           
  Misses         1569     1569           
  Partials        136      136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update d291935...2c3a583. Read the comment docs.

@sunday-okpoluaefe sunday-okpoluaefe merged commit 194f809 into master Jun 16, 2021
@sunday-okpoluaefe sunday-okpoluaefe deleted the sunday-nt-2044-long-translations-for-failed-post branch June 16, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants