Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2071: Update exoplayer, mockito, and timber dependencies to latest versions #1306

Merged
merged 8 commits into from
Jul 1, 2021

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Jun 28, 2021

📲 What

Update exoplayer, mockito, and timber dependencies to latest versions.

🛠 How

  • Updated the gradle file
  • Updated VideoActivity to use latest changes in exoplayer and remove deprecated classes
  • Updated instances of timber that were being used incorrectly according to the linter

📋 QA

  • Test that videos are working properly on the project screen
  • Running the application should show timber logs in logcat
  • CI should catch any errors that may result from updating mockito

Story 📖

NT-2071: Update dependencies with major updates

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #1306 (9ca7125) into master (c469b3c) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1306   +/-   ##
=========================================
  Coverage     74.24%   74.24%           
  Complexity      739      739           
=========================================
  Files           221      221           
  Lines          6655     6655           
  Branches        406      406           
=========================================
  Hits           4941     4941           
  Misses         1578     1578           
  Partials        136      136           
Impacted Files Coverage Δ
.../main/java/com/kickstarter/libs/CurrentConfig.java 68.75% <0.00%> (ø)
...n/java/com/kickstarter/libs/PushNotifications.java 5.43% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c469b3c...9ca7125. Read the comment docs.

Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefect

@leighdouglas leighdouglas merged commit 73ebff4 into master Jul 1, 2021
@leighdouglas leighdouglas deleted the leigh/nt-2071-major-deps branch July 1, 2021 15:58
Arkariang added a commit that referenced this pull request Jul 6, 2021
…ure/NT-2059-update-stripe-sdk

* 'master' of github.com:kickstarter/android-oss:
  NT-1997:UI/UX – Error loading more replies (#1313)
  NT-2095:View Replies show and hide with scrolling (#1312)
  NT-2053:UX – Add pagination to replies (#1311)
  NT-2028: Navigation – Back button should slide view out #1310
  NT-1958: UX – Post a reply (#1305)
  NT-2071: Update exoplayer, mockito, and timber dependencies to latest versions (#1306)
  Set the name as an empty string to prevent the app from crashing. (#1309)
  NT-2069:Refactor Comment Pagination code  (#1308)
  NT-2005: Update Dependencies to Latest Version (#1304)
  NT-2069:Refactor Comment Pagination code (#1303)
  NT-1958: UX – Post a reply (#1301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants