NT-2069:Refactor Comment Pagination code #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1308 +/- ##
=========================================
Coverage 74.24% 74.24%
Complexity 739 739
=========================================
Files 221 221
Lines 6655 6655
Branches 406 406
=========================================
Hits 4941 4941
Misses 1578 1578
Partials 136 136 Continue to review full report at Codecov.
|
| @@ -301,7 +305,7 @@ interface CommentsViewModel { | |||
| .distinctUntilChanged(true) | |||
| .startOverWith(startOverWith) | |||
| .envelopeToListOfData { | |||
| mapToCommentCardDataList(Pair(it, null)) | |||
| mapToCommentCardDataList(Pair(it, this.project)) | |||
There was a problem hiding this comment.
Since project can technically be null, I think it would be best if we put a null check here to guarantee that no crash happens.
There was a problem hiding this comment.
Changed map method to not allow null
Arkariang
added a commit
that referenced
this pull request
Jul 6, 2021
…ure/NT-2059-update-stripe-sdk * 'master' of github.com:kickstarter/android-oss: NT-1997:UI/UX – Error loading more replies (#1313) NT-2095:View Replies show and hide with scrolling (#1312) NT-2053:UX – Add pagination to replies (#1311) NT-2028: Navigation – Back button should slide view out #1310 NT-1958: UX – Post a reply (#1305) NT-2071: Update exoplayer, mockito, and timber dependencies to latest versions (#1306) Set the name as an empty string to prevent the app from crashing. (#1309) NT-2069:Refactor Comment Pagination code (#1308) NT-2005: Update Dependencies to Latest Version (#1304) NT-2069:Refactor Comment Pagination code (#1303) NT-1958: UX – Post a reply (#1301)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fix issue as on master Pagination change scrolling position and crash at the last page
🤔 Why
the compare item wasn't working as it was null for project value
👀 See
Before issue
https://user-images.githubusercontent.com/1075310/123808314-ecb57e00-d8f0-11eb-9ac1-8f234d2885cb.mp4
the Fix
https://user-images.githubusercontent.com/1075310/123807680-5d0fcf80-d8f0-11eb-9cdd-fc75a668e52d.mp4
📋 QA
Open any project with comments and has more than one page and scroll and check pagination
Story 📖
https://kickstarter.atlassian.net/browse/NT-2069