NT-1997:UI/UX β Error loading more replies #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/kickstarter/ui/adapters/RepliesAdapter.kt # app/src/main/java/com/kickstarter/viewmodels/ThreadViewModel.kt # app/src/main/res/layout/activity_thread_layout.xml
# Conflicts: # app/src/main/java/com/kickstarter/ui/activities/ThreadActivity.kt # app/src/main/java/com/kickstarter/ui/adapters/RepliesAdapter.kt # app/src/main/java/com/kickstarter/viewmodels/ThreadViewModel.kt # app/src/main/res/layout/activity_thread_layout.xml
Codecov Report
@@ Coverage Diff @@
## master #1313 +/- ##
=========================================
Coverage 74.12% 74.12%
Complexity 739 739
=========================================
Files 221 221
Lines 6666 6666
Branches 406 406
=========================================
Hits 4941 4941
Misses 1589 1589
Partials 136 136 Continue to review full report at Codecov.
|
Arkariang
reviewed
Jul 6, 2021
| @@ -50,6 +50,9 @@ interface ThreadViewModel { | |||
|
|
|||
| fun isFetchingReplies(): Observable<Boolean> | |||
| fun loadMoreReplies(): Observable<Void> | |||
|
|
|||
| /** Display the bottom pagination Error Cell **/ | |||
There was a problem hiding this comment.
On threads is displayed on top, modify the comment
Arkariang
reviewed
Jul 6, 2021
| this.internalError | ||
| .compose(Transformers.combineLatestPair(onCommentReplies)) | ||
| .filter { | ||
| // it.first.second && |
Arkariang
approved these changes
Jul 6, 2021
Arkariang
added a commit
that referenced
this pull request
Jul 6, 2021
β¦ure/NT-2059-update-stripe-sdk * 'master' of github.com:kickstarter/android-oss: NT-1997:UI/UX β Error loading more replies (#1313) NT-2095:View Replies show and hide with scrolling (#1312) NT-2053:UX β Add pagination to replies (#1311) NT-2028: Navigation β Back button should slide view out #1310 NT-1958: UX β Post a reply (#1305) NT-2071: Update exoplayer, mockito, and timber dependencies to latest versions (#1306) Set the name as an empty string to prevent the app from crashing. (#1309) NT-2069:Refactor Comment Pagination code (#1308) NT-2005: Update Dependencies to Latest Version (#1304) NT-2069:Refactor Comment Pagination code (#1303) NT-1958: UX β Post a reply (#1301)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π² What
handle problems loading more replies
π€ Why
show pagination Error loading extra pages of replies
π How
same as comments we change the view more to the error message and its clickable to retry
π See
Screen_Recording_20210706-154610_Kickstarter.mp4
π QA
Story π
https://kickstarter.atlassian.net/browse/NT-1997