Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2003:UX – Show pending comment dialog #1336

Merged
merged 3 commits into from
Jul 27, 2021
Merged

NT-2003:UX – Show pending comment dialog #1336

merged 3 commits into from
Jul 27, 2021

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Jul 27, 2021

πŸ“² What

Solve issue when pressing back icon with text in the composer to show a dialog in comment activity

πŸ›  How

image

πŸ‘€ See

device-2021-07-27-153848.mp4

πŸ“‹ QA

Press back icon and hardware back key when there is unposted text in the composer

Story πŸ“–

https://kickstarter.atlassian.net/browse/NT-2003

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #1336 (e8e2b89) into master (b754a76) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1336   +/-   ##
=========================================
  Coverage     74.18%   74.18%           
  Complexity      743      743           
=========================================
  Files           221      221           
  Lines          6667     6667           
  Branches        407      407           
=========================================
  Hits           4946     4946           
  Misses         1584     1584           
  Partials        137      137           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update b754a76...e8e2b89. Read the comment docs.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@hadia hadia merged commit ddfb83f into master Jul 27, 2021
@hadia hadia deleted the hadia/fix_back branch July 27, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants