Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2144: Emulator on CI environment #1341

Merged
merged 57 commits into from
Jul 30, 2021
Merged

NT-2144: Emulator on CI environment #1341

merged 57 commits into from
Jul 30, 2021

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Jul 29, 2021

📲 What

🤔 Why

👀 See

  • All the steps to create/run/configure the simulator for screenshot tests
    Screen Shot 2021-07-29 at 11 53 02 AM

  • Screenshot test job and unit test hob running on parallel

Screen Shot 2021-07-29 at 1 40 27 PM

  • The simulator has been launched and it's completely booted.

Screen Shot 2021-07-29 at 2 12 15 PM

| | |

📋 QA

  • Run the CI job again and take a look at the logs to check all the steps are correct.

Story 📖

NT-2144

…into imartin/NT-2144

* 'imartin/NT-2144' of github.com:kickstarter/android-oss:
  Updated config.yml
…into imartin/NT-2144

* 'imartin/NT-2144' of github.com:kickstarter/android-oss:
  Updated config.yml
  Updated config.yml
  Updated config.yml
…tin/NT-2144

* 'master' of github.com:kickstarter/android-oss:
  NT-2139:Screenshot Test Comment Composer (#1338)
- start the emulator
- run the emulator

Via the android orb and the new android machine
- running with android-machine executor
- using API 29 for now
This reverts commit 208c2db.
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1341 (6932d09) into master (1898158) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1341   +/-   ##
=========================================
  Coverage     74.16%   74.16%           
  Complexity      743      743           
=========================================
  Files           221      221           
  Lines          6669     6669           
  Branches        409      409           
=========================================
  Hits           4946     4946           
  Misses         1584     1584           
  Partials        139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1898158...6932d09. Read the comment docs.

@Arkariang Arkariang changed the title NT-2144: S NT-2144: Emulator on CI environment Jul 29, 2021
@Arkariang Arkariang marked this pull request as ready for review July 29, 2021 22:59
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working after merge branch 🎉🎉

@Arkariang Arkariang merged commit d9e6734 into master Jul 30, 2021
@Arkariang Arkariang deleted the imartin/NT-2144 branch July 30, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants