Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix limit and left #1349

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Fix limit and left #1349

merged 2 commits into from
Aug 6, 2021

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Aug 5, 2021

📲 What

remove static UI , and check for components name

🤔 Why

there was an issue showing a fixed number for all projects add-on

👀 See

image

📋 QA

Open production project and compare with ios
https://www.kickstarter.com/projects/strangewise/fearsome-weirdos-harvest-of-horrors

Story 📖

https://kickstarter.atlassian.net/browse/NT-2145

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! as soon as the linter is fixed feel free to merge

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #1349 (df5706c) into master (6c9dba9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1349   +/-   ##
=========================================
  Coverage     74.16%   74.16%           
  Complexity      743      743           
=========================================
  Files           221      221           
  Lines          6669     6669           
  Branches        409      409           
=========================================
  Hits           4946     4946           
  Misses         1584     1584           
  Partials        139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9dba9...df5706c. Read the comment docs.

@hadia hadia merged commit c29e3ed into master Aug 6, 2021
@hadia hadia deleted the hadia/add_on_tag branch August 6, 2021 12:28
Arkariang added a commit that referenced this pull request Aug 6, 2021
…tin/ready-for-ruby-3

* 'master' of github.com:kickstarter/android-oss:
  [No-Jira]: Updated gems + bundler (#1347)
  Fix limit and left (#1349)

# Conflicts:
#	Gemfile
#	Gemfile.lock
Arkariang added a commit that referenced this pull request Aug 6, 2021
…tin/launch-simulator-ok

* 'master' of github.com:kickstarter/android-oss:
  [No-jira]: Ready for Ruby 3.0 (#1350)
  [No-Jira]: Updated gems + bundler (#1347)
  Fix limit and left (#1349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants