Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate update.java to kotlin and deprecate AutoParcel #1553

Merged

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 2, 2022

📲 What

  • Convert update and UpdateFactory to kotlin
  • Migrate to parcelize

🤔 Why

Deprecation of autoparcel library in an ongoing effort to migrate to android's in-house parcelize.

👀 See

  • No user facing changes

📋 QA

  • Test project updates

Story 📖

https://kickstarter.atlassian.net/browse/NTV-387

@hadia hadia added the migration Migration Java to Kotlin label Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #1553 (4a23da9) into master (8a0d3e9) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1553    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         355     355            
  Lines       14214   14367   +153     
  Branches     1579    1604    +25     
=======================================
- Misses      14214   14367   +153     
Impacted Files Coverage Δ
...va/com/kickstarter/mock/factories/UpdateFactory.kt 0.00% <0.00%> (ø)
app/src/main/java/com/kickstarter/models/Update.kt 0.00% <0.00%> (ø)
...java/com/kickstarter/viewmodels/UpdateViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a0d3e9...4a23da9. Read the comment docs.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hadia hadia merged commit d636f94 into master Mar 3, 2022
@hadia hadia deleted the hadia/NTV-387_Migrate_update_to_kotlin_and_deprecate_Autoparce branch March 3, 2022 18:29
Arkariang added a commit that referenced this pull request Mar 8, 2022
…tin/NTV-319-Substitute-BoolSharedPrefs-BoolDataStore

* 'master' of github.com:kickstarter/android-oss:
  - revert back gradle version
  Migrate update.java to kotlin and deprecate AutoParcel (#1553)
Arkariang added a commit that referenced this pull request Mar 10, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss:
  NTV-410 && NTV-406: Bug fixing. (#1562)
  NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559)
  WEB-361: Fix flaky date time test in RefTagUtils (#1561)
  NTV-423: bug fixing on Campaign tabg (#1560)
  NTV-361: Fix flaky tests related to datetime (#1558)
  Update comment counts to include replies (#1555)
  - revert back gradle version
  Migrate update.java to kotlin and deprecate AutoParcel (#1553)
  NTV-366: DiscoveryParams migrated to kotlin and deprecated autoparcel (#1554)
  NTV-383: Migrate Message.java to kotlin and deprecate Autoparcel (#1551)
  NTV-415 :Jacoco code coverage only looking throw Java classes (#1550)
  NTV-399  Reply comments created with invalid commentable (#1549)
  NTV-414: /v1/activities was called from the app several times #1548
  NTV-412: Hide old campaign links #1547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants