WEB-361: Fix flaky date time test in RefTagUtils #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kstarter/android-oss into leigh/ntv-361-flaky-datetime
Codecov Report
@@ Coverage Diff @@
## master #1561 +/- ##
=========================================
Coverage 76.10% 76.10%
Complexity 1507 1507
=========================================
Files 355 355
Lines 14365 14365
Branches 1604 1604
=========================================
Hits 10932 10932
Misses 2590 2590
Partials 843 843 Continue to review full report at Codecov.
|
Arkariang
approved these changes
Mar 8, 2022
Arkariang
added a commit
that referenced
this pull request
Mar 10, 2022
…e/NTV-411-integrate-payment-sheet * 'master' of github.com:kickstarter/android-oss: NTV-410 && NTV-406: Bug fixing. (#1562) NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559) WEB-361: Fix flaky date time test in RefTagUtils (#1561) NTV-423: bug fixing on Campaign tabg (#1560) NTV-361: Fix flaky tests related to datetime (#1558) Update comment counts to include replies (#1555) - revert back gradle version Migrate update.java to kotlin and deprecate AutoParcel (#1553) NTV-366: DiscoveryParams migrated to kotlin and deprecated autoparcel (#1554) NTV-383: Migrate Message.java to kotlin and deprecate Autoparcel (#1551) NTV-415 :Jacoco code coverage only looking throw Java classes (#1550) NTV-399 Reply comments created with invalid commentable (#1549) NTV-414: /v1/activities was called from the app several times #1548 NTV-412: Hide old campaign links #1547
Arkariang
added a commit
that referenced
this pull request
Mar 18, 2022
…tin/NTV-319-Substitute-BoolSharedPrefs-BoolDataStore * 'master' of github.com:kickstarter/android-oss: NTV-385: Migrate to kotlin and deprecate autoparcel ProjectNotification model (#1567) NTV-429: Gifs on last row on campaign tab not loading on first try (#1566) NTV-384 : Migrate MessageThread.java to kotlin and deprecate Autoparcel (#1565) NTV-386: Migrate SurveyResponse.java to kotlin and deprecate Autoparcel (#1564) NTV-422 DeepLinks bug while QA (#1563) NTV-410 && NTV-406: Bug fixing. (#1562) NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559) WEB-361: Fix flaky date time test in RefTagUtils (#1561) NTV-423: bug fixing on Campaign tabg (#1560) NTV-361: Fix flaky tests related to datetime (#1558) Update comment counts to include replies (#1555)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Added 1 second to date time in unit tests to fix flakey test.
📋 QA
Run
RefTagUtilsTesta few times, ensure it is not failing sometimesStory 📖
NTV-361: Flaky tests related to DateTime.now() usages in unit tests
NTV-425: Flaky tests related to DateTime.now() usages in unit tests