Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel #1559

Merged
merged 8 commits into from Mar 9, 2022

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Mar 7, 2022

📲 What

  • Convert Message.java to kotlin
  • Migrate to parcelize

🤔 Why

Deprecation of autoparcel library in an ongoing effort to migrate to android's in-house parcelize.

📋 QA

  • Check the activity screen and make sure all the timestamps and information is correct

Story 📖

NTV-382: Migrate Activity.java to kotlin and deprecate Autoparcel
WEB-358: Migrate Activity.java to kotlin and deprecate Autoparcel

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #1559 (3ae122f) into master (fb0ab4c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1559      +/-   ##
============================================
- Coverage     76.10%   76.09%   -0.01%     
  Complexity     1507     1507              
============================================
  Files           355      355              
  Lines         14365    14366       +1     
  Branches       1604     1605       +1     
============================================
  Hits          10932    10932              
- Misses         2590     2591       +1     
  Partials        843      843              
Impacted Files Coverage Δ
.../com/kickstarter/libs/utils/AnalyticEventsUtils.kt 73.71% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb0ab4c...3ae122f. Read the comment docs.

@leighdouglas leighdouglas force-pushed the leigh/ntv-382-activity-parcelize branch from bd2ae74 to 8c70e9d Compare March 8, 2022 17:18
@leighdouglas leighdouglas marked this pull request as ready for review March 8, 2022 17:19
@leighdouglas leighdouglas added maintenance 🗜 migration Migration Java to Kotlin labels Mar 8, 2022
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Tested with my personal account and with the realnative one

@leighdouglas leighdouglas merged commit 6b34e45 into master Mar 9, 2022
@leighdouglas leighdouglas deleted the leigh/ntv-382-activity-parcelize branch March 9, 2022 00:25
Arkariang added a commit that referenced this pull request Mar 9, 2022
…tin/ntv-410

* 'master' of github.com:kickstarter/android-oss:
  NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559)
Arkariang added a commit that referenced this pull request Mar 10, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss:
  NTV-410 && NTV-406: Bug fixing. (#1562)
  NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559)
  WEB-361: Fix flaky date time test in RefTagUtils (#1561)
  NTV-423: bug fixing on Campaign tabg (#1560)
  NTV-361: Fix flaky tests related to datetime (#1558)
  Update comment counts to include replies (#1555)
  - revert back gradle version
  Migrate update.java to kotlin and deprecate AutoParcel (#1553)
  NTV-366: DiscoveryParams migrated to kotlin and deprecated autoparcel (#1554)
  NTV-383: Migrate Message.java to kotlin and deprecate Autoparcel (#1551)
  NTV-415 :Jacoco code coverage only looking throw Java classes (#1550)
  NTV-399  Reply comments created with invalid commentable (#1549)
  NTV-414: /v1/activities was called from the app several times #1548
  NTV-412: Hide old campaign links #1547
Arkariang added a commit that referenced this pull request Mar 18, 2022
…tin/NTV-319-Substitute-BoolSharedPrefs-BoolDataStore

* 'master' of github.com:kickstarter/android-oss:
  NTV-385: Migrate to kotlin and deprecate autoparcel ProjectNotification model (#1567)
  NTV-429: Gifs on last row on campaign tab not loading on first try (#1566)
  NTV-384 : Migrate MessageThread.java to kotlin and deprecate Autoparcel (#1565)
  NTV-386: Migrate SurveyResponse.java to kotlin and deprecate Autoparcel (#1564)
  NTV-422 DeepLinks bug while QA (#1563)
  NTV-410 && NTV-406: Bug fixing. (#1562)
  NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559)
  WEB-361: Fix flaky date time test in RefTagUtils (#1561)
  NTV-423: bug fixing on Campaign tabg (#1560)
  NTV-361: Fix flaky tests related to datetime (#1558)
  Update comment counts to include replies (#1555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance 🗜 migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants