New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel #1559
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1559 +/- ##
============================================
- Coverage 76.10% 76.09% -0.01%
Complexity 1507 1507
============================================
Files 355 355
Lines 14365 14366 +1
Branches 1604 1605 +1
============================================
Hits 10932 10932
- Misses 2590 2591 +1
Partials 843 843
Continue to review full report at Codecov.
|
bd2ae74
to
8c70e9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Tested with my personal account and with the realnative one
…tin/ntv-410 * 'master' of github.com:kickstarter/android-oss: NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559)
…e/NTV-411-integrate-payment-sheet * 'master' of github.com:kickstarter/android-oss: NTV-410 && NTV-406: Bug fixing. (#1562) NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559) WEB-361: Fix flaky date time test in RefTagUtils (#1561) NTV-423: bug fixing on Campaign tabg (#1560) NTV-361: Fix flaky tests related to datetime (#1558) Update comment counts to include replies (#1555) - revert back gradle version Migrate update.java to kotlin and deprecate AutoParcel (#1553) NTV-366: DiscoveryParams migrated to kotlin and deprecated autoparcel (#1554) NTV-383: Migrate Message.java to kotlin and deprecate Autoparcel (#1551) NTV-415 :Jacoco code coverage only looking throw Java classes (#1550) NTV-399 Reply comments created with invalid commentable (#1549) NTV-414: /v1/activities was called from the app several times #1548 NTV-412: Hide old campaign links #1547
…tin/NTV-319-Substitute-BoolSharedPrefs-BoolDataStore * 'master' of github.com:kickstarter/android-oss: NTV-385: Migrate to kotlin and deprecate autoparcel ProjectNotification model (#1567) NTV-429: Gifs on last row on campaign tab not loading on first try (#1566) NTV-384 : Migrate MessageThread.java to kotlin and deprecate Autoparcel (#1565) NTV-386: Migrate SurveyResponse.java to kotlin and deprecate Autoparcel (#1564) NTV-422 DeepLinks bug while QA (#1563) NTV-410 && NTV-406: Bug fixing. (#1562) NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559) WEB-361: Fix flaky date time test in RefTagUtils (#1561) NTV-423: bug fixing on Campaign tabg (#1560) NTV-361: Fix flaky tests related to datetime (#1558) Update comment counts to include replies (#1555)
📲 What
parcelize
🤔 Why
Deprecation of
autoparcel
library in an ongoing effort to migrate to android's in-houseparcelize
.📋 QA
Story 📖
NTV-382: Migrate Activity.java to kotlin and deprecate Autoparcel
WEB-358: Migrate Activity.java to kotlin and deprecate Autoparcel